Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update: Add kubelet to user_known_chmod_applications list #944

Merged
merged 1 commit into from
Dec 1, 2019
Merged

rule update: Add kubelet to user_known_chmod_applications list #944

merged 1 commit into from
Dec 1, 2019

Conversation

rung
Copy link
Contributor

@rung rung commented Dec 1, 2019

Signed-off-by: Hiroki Suezawa [email protected]

What type of PR is this?

/kind bug
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

  • What this PR does
    • Add kubelet to user_known_chmod_applications list
  • Why we need it
    • To reduce false positives
    • I got massive false positives of "Setuid or setgid bit is set via chmod", because kubelet uses chmod syscall every time mounting configmap, secret and so on.
    • Sample Flase Positive Log(GKE 1.14.8-gke.12 on Ubuntu)
output: "14:02:11.496777755: Notice Setuid or setgid bit is set via chmod (fd=<NA> filename=/var/lib/kubelet/pods/1029fd94-140a-11ea-93b8-42010a80001b/volumes/kubernetes.io~secret/heapster-token-5rjw6 mode=S_IXOTH|S_IWOTH|S_IROTH|S_IXGRP|S_IWGRP|S_IRGRP|S_IXUSR|S_IWUSR|S_IRUSR|S_ISVTX|S_ISGID user=root process=kubelet command=kubelet --v=2 --cloud-provider=gce --experimental-check-node-capabilities-before-mount=true --experimental-mounter-path=/home/kubernetes/containerized_mounter/mounter --cert-dir=/var/lib/kubelet/pki/ --cni-bin-dir=/home/kubernetes/bin --kubeconfig=/var/lib/kubelet/kubeconfig --experimental-kernel-memcg-notification=true --max-pods=110 --non-masquerade-cidr=0.0.0.0/0 --network-plugin=kubenet --node-labels=beta.kubernetes.io/fluentd-ds-ready=true,cloud.google.com/gke-nodepool=default-pool,cloud.google.com/gke-os-distribution=ubuntu --volume-plugin-dir=/home/kubernetes/flexvolume --bootstrap-kubeconfig=/var/lib/kubelet/bootstrap-kubeconfig --node-status-max-images=25 --registry-qps=10 --registry-burst=20 --config /home/kubernetes/kubelet-config.yaml --pod-sysctls=net.core.somaxconn=1024,net.ipv4.conf.all.accept_redirects=0,net.ipv4.conf.all.forwarding=1,net.ipv4.conf.all.route_localnet=1,net.ipv4.conf.default.forwarding=1,net.ipv4.ip_forward=1,net.ipv4.tcp_fin_timeout=60,net.ipv4.tcp_keepalive_intvl=75,net.ipv4.tcp_keepalive_probes=9,net.ipv4.tcp_keepalive_time=7200,net.ipv4.tcp_max_syn_backlog=128,net.ipv4.tcp_max_tw_buckets=16384,net.ipv4.tcp_rmem=4096 87380 6291456,net.ipv4.tcp_syn_retries=6,net.ipv4.tcp_tw_reuse=0,net.ipv4.tcp_wmem=4096 16384 4194304,net.netfilter.nf_conntrack_generic_timeout=600,net.netfilter.nf_conntrack_tcp_timeout_close_wait=3600,net.netfilter.nf_conntrack_tcp_timeout_established=86400 container_id=host container_name=host image=<NA>:<NA>) k8s.ns=<NA> k8s.pod=<NA> container=host k8s.ns=<NA> k8s.pod=<NA> container=host k8s.ns=<NA> k8s.pod=<NA> container=host" 

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

rules(list user_known_chmod_applications): add kubelet

@fntlnz
Copy link
Contributor

fntlnz commented Dec 1, 2019

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Dec 1, 2019
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see you again @rung !
LGTM

@poiana
Copy link
Contributor

poiana commented Dec 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Dec 1, 2019

LGTM label has been added.

Git tree hash: fd15f344187c7d864986c9ee4314ff85187d1534

@fntlnz fntlnz merged commit c736a84 into falcosecurity:dev Dec 1, 2019
@rung rung deleted the rule-add-kubelet-chmod branch December 1, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants