Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: initial owners files for Falco #659

Merged
merged 1 commit into from
Jun 11, 2019
Merged

new: initial owners files for Falco #659

merged 1 commit into from
Jun 11, 2019

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 11, 2019

Signed-off-by: Lorenzo Fontana [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flaky-test

If contributing rules or changes to rules, please make sure to uncomment the appropriate kind

/kind rule/update
/kind rule/create

Any specific area of the project related to this PR?

/area engine
/area rules
/area deployment
/area integrations
/area examples

What this PR does / why we need it:
Initial owners file.
Will make it better on the go but for now it allows us to review PRs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit be9c6b4 into dev Jun 11, 2019
@poiana poiana deleted the owners-files branch June 11, 2019 01:40
@fntlnz
Copy link
Contributor Author

fntlnz commented Jun 11, 2019

Forced merge since prow was ineffective without owners file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants