Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Puppet module #537

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Update the Puppet module #537

merged 3 commits into from
Feb 21, 2019

Conversation

JPLachance
Copy link
Contributor

Greetings!

I noticed the Puppet module is a little outdated compared to this repository. I also noticed the installation was not working because the DEB repository was not managed by this module. This PR should fix that!

A list of the changes:
* Apply puppet-lint recommendations
* Update the README since the project moved from draios to falcosecurity in GitHub
* Move parameters in their own file
Add the DEB repository automatically (based on https://github.com/garethr/garethr-sysdig/blob/master/manifests/install.pp)
Add the EPEL repository automatically (based on https://github.com/garethr/garethr-sysdig/blob/master/manifests/install.pp)
Add a logrotate configuration
* Update the configuration file with all the latest updates

🆘 Please note that I'm not a Puppet expert 😄

falco-CLA-1.0-contributing-entity: Coveo Solutions Inc.
falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance [email protected]

* Apply puppet-lint recommendations
* Update the README since the project moved from draios to falcosecurity in GitHub
* Move parameters in their own file
  Add the DEB repository automatically
  Add the EPEL repository automatically
  Add a logrotate configuration
* Update the configuration file with all the latest updates

falco-CLA-1.0-contributing-entity: Coveo Solutions Inc.
falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance <[email protected]>
@mstemm mstemm self-requested a review February 19, 2019 20:32
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall thanks for the contribution! If you could just make the recommended changes so it will install with puppet 4, that would be handy.

* Set dependencies between classes
* Set the class order
* Apply mstemm's code review
* Use a working version of puppetlabs-apt
* Use dependencies to be compatible with Puppet 4.7 and above
@mstemm mstemm merged commit 9c57473 into falcosecurity:dev Feb 21, 2019
mstemm added a commit that referenced this pull request Feb 21, 2019
0.2.0 was released as a part of testing an early version in
#537, and can't be
overwritten, so publish as 0.3.0.
@mstemm mstemm mentioned this pull request Feb 21, 2019
mstemm added a commit that referenced this pull request Feb 21, 2019
0.2.0 was released as a part of testing an early version in
#537, and can't be
overwritten, so publish as 0.3.0.
@JPLachance JPLachance deleted the puppet-module-update branch March 1, 2019 17:02
leogr pushed a commit to falcosecurity/rules that referenced this pull request Dec 21, 2022
0.2.0 was released as a part of testing an early version in
falcosecurity/falco#537, and can't be
overwritten, so publish as 0.3.0.
leogr pushed a commit to falcosecurity/rules that referenced this pull request Dec 21, 2022
0.2.0 was released as a part of testing an early version in
falcosecurity/falco#537, and can't be
overwritten, so publish as 0.3.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants