-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
further improvements outputs impl. #1443
Conversation
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
9c64273
to
f6c7deb
Compare
On previously modified files. Signed-off-by: Leonardo Grasso <[email protected]>
LGTM label has been added. Git tree hash: 8d803a0bafd2d8373a6bfd163838c26348edbd96
|
/milestone 0.27.0 |
Signed-off-by: Leonardo Grasso <[email protected]>
…lco_common Signed-off-by: Leonardo Grasso <[email protected]>
LGTM label has been added. Git tree hash: f189958bf82439ceb4ffb6d16beb54dda0948ce5
|
Put this temporarily on |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR follows up #1412 and is preparatory for a future PR (I will make it later) that implements non-blocking outputs (as per #1417).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I decided to include those small changes inside a separate PR (this one) to facilitate the reviewing process.
/cc @leodido
/cc @fntlnz
Does this PR introduce a user-facing change?: