Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further improvements outputs impl. #1443

Merged
merged 5 commits into from
Oct 26, 2020
Merged

further improvements outputs impl. #1443

merged 5 commits into from
Oct 26, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Oct 14, 2020

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR follows up #1412 and is preparatory for a future PR (I will make it later) that implements non-blocking outputs (as per #1417).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I decided to include those small changes inside a separate PR (this one) to facilitate the reviewing process.
/cc @leodido
/cc @fntlnz

Does this PR introduce a user-facing change?:

NONE

On previously modified files.

Signed-off-by: Leonardo Grasso <[email protected]>
@poiana poiana added size/M and removed size/S labels Oct 14, 2020
@leogr leogr changed the title wip: futher improvements outputs impl. further improvements outputs impl. Oct 14, 2020
fntlnz
fntlnz previously approved these changes Oct 15, 2020
@poiana
Copy link
Contributor

poiana commented Oct 15, 2020

LGTM label has been added.

Git tree hash: 8d803a0bafd2d8373a6bfd163838c26348edbd96

@leogr
Copy link
Member Author

leogr commented Oct 15, 2020

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Oct 15, 2020
@leogr leogr requested a review from fntlnz October 20, 2020 14:27
@poiana poiana added the lgtm label Oct 20, 2020
@poiana
Copy link
Contributor

poiana commented Oct 20, 2020

LGTM label has been added.

Git tree hash: f189958bf82439ceb4ffb6d16beb54dda0948ce5

@leogr
Copy link
Member Author

leogr commented Oct 21, 2020

Put this temporarily on
/hold
to let other PRs merged in

@leogr
Copy link
Member Author

leogr commented Oct 21, 2020

/hold cancel

@poiana
Copy link
Contributor

poiana commented Oct 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c188f4a into master Oct 26, 2020
@poiana poiana deleted the chore/improve-outputs branch October 26, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants