chore(rules): Rule exceptions for ibm cloud #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibalizer
force-pushed
the
ibmcloud_rules
branch
3 times, most recently
from
cd7e44a
to
3cc7960
Compare
Kaizhe
reviewed
Jul 31, 2020
Kaizhe
suggested changes
Aug 5, 2020
nibalizer
force-pushed
the
ibmcloud_rules
branch
from
3cc7960
to
b6c8326
Compare
nibalizer
force-pushed
the
ibmcloud_rules
branch
from
b6c8326
to
950bb0b
Compare
|
Hey @nibalizer it seems that some integration tests are not passing, also this PR needs to be rebased on top of the current master branch. Thanks in advance |
|
Yes I can do that. Also check this PR number. |
nibalizer
force-pushed
the
ibmcloud_rules
branch
from
950bb0b
to
0b55aa3
Compare
leogr
requested changes
Oct 8, 2020
There was a problem hiding this comment.
The integrations test still report the following error:
Wed Oct 7 20:59:41 2020: Runtime error: Compilation error when compiling "(container.image.repository in (gcr.io/google_containers/hyperkube-amd64,
gcr.io/google_containers/kube2sky, docker.io/sysdig/falco,
docker.io/sysdig/sysdig, docker.io/falcosecurity/falco,
sysdig/falco, sysdig/sysdig, falcosecurity/falco)
or (container.image.repository in icr.io/ext/sysdig/agent, registry.ng.bluemix.net/armada-master/olm, registry.ng.bluemix.net/armada-master/metrics-server-amd64)
or (k8s.ns.name = "kube-system"))
": 278: syntax error, unexpected 'icr', expecting '('
---
- macro: k8s_containers
condition: >
(container.image.repository in (gcr.io/google_containers/hyperkube-amd64,
gcr.io/google_containers/kube2sky, docker.io/sysdig/falco,
docker.io/sysdig/sysdig, docker.io/falcosecurity/falco,
sysdig/falco, sysdig/sysdig, falcosecurity/falco)
or (container.image.repository in ibm_cloud_containers)
or (k8s.ns.name = "kube-system"))
---. Exiting.
0b55aa3
to
6948c6a
Compare
leogr
force-pushed
the
ibmcloud_rules
branch
from
8117435
to
bd2a03a
Compare
|
Update: I have rebased this PR to let the new CI job run. I will re-approve soon. |
leogr
previously approved these changes
Feb 18, 2021
|
LGTM label has been added. Git tree hash: 90a13f51c7da7b00c7905d6b001fb34f29f7f2e8
|
fntlnz
previously approved these changes
Feb 19, 2021
|
Just add my observation here, in PR 1337 we have the list a commercial image(sysdig/agent) from cloud vendor. We haven't decided whether we should allow commercial images in the exception. Just approve for now, probably will change the list when a decision is made. |
Kaizhe
previously approved these changes
Feb 19, 2021
Whitelist ibm images for connecting to k8s api server IBM Observability by Sysdig has a vendored sysdig/agent image. IBM's Kubernetes Service ships with an operator manager. Example: 19:12:45.090908160: Notice Unexpected connection to K8s API Server from container (command=catalog -namespace ibm-system -configmapServerImage=registry.ng.bluemix.net/armada-master/configmap-operator-registry:v1.6.1 k8s.ns=ibm-system k8s.pod=catalog-operator-6495d76869-ncl2z container=4ad7a04fa1e0 image=registry.ng.bluemix.net/armada-master/olm:0.14.1-IKS-1 connection=172.30.108.219:48200->172.21.0.1:443) k8s.ns=ibm-system k8s.pod=catalog-operator-6495d76869-ncl2z container=4ad7a04fa1e0 IBM's Kubernetes service also ships with a metrics collecting agent Signed-off-by: Spencer Krum <[email protected]>
leogr
force-pushed
the
ibmcloud_rules
branch
from
bd2a03a
to
e69c38e
Compare
Signed-off-by: Spencer Krum <[email protected]>
leogr
force-pushed
the
ibmcloud_rules
branch
from
e69c38e
to
3a05bfc
Compare
leogr
approved these changes
Feb 19, 2021
|
LGTM label has been added. Git tree hash: 2ae4f3c9e8637421a94cd1b54019430b15b00758
|
leodido
approved these changes
Feb 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spencer Krum [email protected]
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Rule exceptions for ibm cloud
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: