Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(integration): move /integration to contrib repo #1157

Merged
merged 1 commit into from
May 13, 2020
Merged

update(integration): move /integration to contrib repo #1157

merged 1 commit into from
May 13, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 23, 2020

Signed-off-by: Leonardo Grasso [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
As discussed with the community we want to move /integrations to the contrib. Thus we have to clean it up here.

Which issue(s) this PR fixes:

Fixes #1145

Special notes for your reviewer:
👉 falcosecurity/contrib#3
/hold

/milestone 0.23.0

Does this PR introduce a user-facing change?:

update(integration): move `/integrations` to `contrib` repo

@poiana poiana added this to the 0.23.0 milestone Apr 23, 2020
@poiana poiana requested review from fntlnz and Kaizhe April 23, 2020 07:41
@poiana poiana added the lgtm label Apr 24, 2020
@poiana
Copy link
Contributor

poiana commented Apr 24, 2020

LGTM label has been added.

Git tree hash: 67e076680a0565f0d1758d58e07e635e215ba263

@leogr
Copy link
Member Author

leogr commented Apr 24, 2020

@kris-nova
I will cancel "hold" as soon as falcosecurity/falco-website#184 gets done

@fntlnz
Copy link
Contributor

fntlnz commented Apr 29, 2020

🧹🧹🧹🧹🧹🧹 Cleaning!

@poiana
Copy link
Contributor

poiana commented Apr 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced May 4, 2020
Merged
Merged
@leogr
Copy link
Member Author

leogr commented May 6, 2020

As per #1184

@leogr leogr mentioned this pull request May 13, 2020
Merged
@leogr
Copy link
Member Author

leogr commented May 13, 2020

/hold cancel

@poiana poiana merged commit ede2ef8 into master May 13, 2020
@poiana poiana deleted the cleanup/integrations branch May 13, 2020 13:15
@JPLachance
Copy link
Contributor

Quick question: Did someone create a new repository for the Falco Puppet module? Did someone update the Puppet forge readme? 😄

@leogr
Copy link
Member Author

leogr commented Jun 3, 2020 •
edited
Loading

Quick question: Did someone create a new repository for the Falco Puppet module? Did someone update the Puppet forge readme?

Hi @JPLachance

the Puppet module was moved here and is currently in sandbox level.
cc @maxgio92

The Puppet forge readme seems to be outdated :)
Not sure who can help out with that 👀

@poiana poiana requested a review from maxgio92 June 3, 2020 21:35
@warmfusion
Copy link

For those who find themselves here trying to find things like puppet modules;

The 'contrib' repos mentioned all over the place are in fact now called 'Falcon Evolution' are found here

https://github.com/falcosecurity/evolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

@leodido leodido leodido approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@maxgio92 maxgio92 Awaiting requested review from maxgio92

Assignees

@leodido leodido

@fntlnz fntlnz

Labels
approved dco-signoff: yes kind/cleanup lgtm release-note size/XXL
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

Move "integrations" to another repo
6 participants
@leogr @poiana @fntlnz @JPLachance @warmfusion @leodido