Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the path of proto files into the Makefile #18

Closed
leodido opened this issue Oct 5, 2019 · 0 comments · Fixed by #22
Closed

Update the path of proto files into the Makefile #18

leodido opened this issue Oct 5, 2019 · 0 comments · Fixed by #22
Labels
kind/feature New feature or request

Comments

@leodido
Copy link
Member

leodido commented Oct 5, 2019

What would you like to be added:

We need to update the path of the proto file(s).

Currently they still points to the branch in Falco where they were done.

client-go/Makefile

Line 6 in 60a1c51

PROTO_URLS := https://raw.githubusercontent.com/falcosecurity/falco/feat/grpc-server-poc/userspace/falco/schema.proto https://raw.githubusercontent.com/falcosecurity/falco/feat/grpc-server-poc/userspace/falco/output.proto

Why is this needed:

We need it to point to the dev branch of Falco (since it will become the default and the master branch soon).
@leodido leodido added the kind/feature New feature or request label Oct 5, 2019
leodido added a commit that referenced this issue Oct 28, 2019
@leodido
update: grab proto from dev (fixes #18)
70c4815 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido mentioned this issue Oct 28, 2019
Merged
poiana pushed a commit that referenced this issue Oct 28, 2019
@leodido @poiana
update: grab proto from dev (fixes #18)
f667342 
Signed-off-by: Leonardo Di Donato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update: grab proto from dev (fixes #18) falcosecurity/client-go
1 participant
@leodido