Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] - Add hm3d example scenes to ci test assets #2303

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[CI] - Add hm3d example scenes to ci test assets #2303

merged 2 commits into from
Jan 22, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jan 19, 2024

Motivation and Context

They should be there so tests are not skipped.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 January 19, 2024 21:08
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 19, 2024
@aclegg3 aclegg3 merged commit 7819c6f into main Jan 22, 2024
10 checks passed
@aclegg3 aclegg3 deleted the CI]-add-hm3d-example-to-ci-test-assets branch January 22, 2024 16:26
@jturner65 jturner65 mentioned this pull request Jan 23, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @jturner65 @facebook-github-bot