Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--PBR Primitive support and gl context bugfix #2235

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR introduces PBR material support and generation for primitives and generated meshes such as trajectories, which were formerly restricted to just phong materials, which looked out of place in scenes that were predominantly rendered using PBR with image-based lighting. This also adds vertex color support for PBR materials. Lastly, this also fixes a bug that was present if trying to build a PBR containing scene without a context (which was being done in a few of the tests).

This functionality was originally going to be part of the PBRTesting PR but I chose to go a different direction with that test due to the difficulty in assigning custom materials to primitive assets on creation.

How Has This Been Tested

C and python tests pass locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested review from aclegg3 and 0mdc October 10, 2023 16:52
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 10, 2023
@jturner65
Copy link
Contributor Author

jturner65 commented Oct 10, 2023

PBR primitives with default IBL environment map.
pbrPrimsEnvMap1

PBR primitives in the same scene with alternate IBL environment map

pbrPrimsEnvMap2

Same scene with yet another different environment map.

pbrPrimsEnvMap3

@jturner65
Copy link
Contributor Author

Vertex color demo via a gradient on a generated metallic trajectory
gradientMetalTrajs

@jturner65 jturner65 merged commit 8b016d7 into main Oct 10, 2023
1 check passed
@jturner65 jturner65 deleted the PBR_PrimitiveSupport branch October 10, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants