--PBR Primitive support and gl context bugfix #2235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces PBR material support and generation for primitives and generated meshes such as trajectories, which were formerly restricted to just phong materials, which looked out of place in scenes that were predominantly rendered using PBR with image-based lighting. This also adds vertex color support for PBR materials. Lastly, this also fixes a bug that was present if trying to build a PBR containing scene without a context (which was being done in a few of the tests).
This functionality was originally going to be part of the PBRTesting PR but I chose to go a different direction with that test due to the difficulty in assigning custom materials to primitive assets on creation.
How Has This Been Tested
C and python tests pass locally.
Types of changes
Checklist