Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Address HBAO image transparency oddness; remove unused variable. #2214

Merged
merged 1 commit into from
Sep 26, 2023
Merged

--Address HBAO image transparency oddness; remove unused variable. #2214

merged 1 commit into from
Sep 26, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Image captures of scenes containing HBAO effect were demonstrating strange transparency-related artifacts due to the HBAO effect also being present in the alpha channel and an improper blend being performed. This PR addresses this by correcting the blend mechanism. New Test/ground truth images are also generated. Lastly, an unused value is removed.

How Has This Been Tested

C and python tests pass locally. New test images are synthesized to account for the new blend algorithm for the HBAO output framebuffer.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 26, 2023
@jturner65 jturner65 requested review from aclegg3 and mosra September 26, 2023 17:51
aclegg3
aclegg3 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jturner65 and @mosra for fixing this so fast! 💪

@jturner65 jturner65 merged commit 9826bd1 into main Sep 26, 2023
1 check passed
@jturner65 jturner65 deleted the HBAO_BlendAndFixes branch September 26, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@mosra mosra mosra approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jturner65 @mosra @aclegg3 @facebook-github-bot