Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[Bugfix] Add new fields to test asset skinned_prism.ao_config.json. #2188

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR removes a deprecated field and adds the new fields introduced in the "ArticulatedObject attributes and managers" PR to the test asset "data/test_assets/urdf/skinned_prism.ao_config.json", except for "urdf_filepath" which is purposely left blank to test that the config load process will successfully find the pertinent urdf, which must reside in the same directory as the json config if it is not specified explicitly in the json.

How Has This Been Tested

Locally c and python tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 17, 2023
@jturner65 jturner65 requested a review from aclegg3 August 17, 2023 14:41
@jturner65 jturner65 merged commit 8524de7 into main Aug 17, 2023
@jturner65 jturner65 deleted the AO_FixesCleanup branch August 17, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants