Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx-replay: Record scene graph deletions. #1975

Merged
merged 6 commits into from
Dec 22, 2022

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 22, 2022

Motivation and Context

When the simulator changes scene, the previous scene graph is not deleted. Because Recorder relies on scene node deletion to issue deletion entries to gfx-replay, the previous scene is not cleared from the replay renderer.

This changeset adds a method to delete all gfx-replay nodes within a scene graph so that the replay renderer can correctly render process scene changes.

How Has This Been Tested

Tested through Python viewer.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from mosra and eundersander December 22, 2022 04:25
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 22, 2022
@0mdc 0mdc force-pushed the gfx-replay-scene-deletion branch from 73451a3 to 6ee6be6 Compare December 22, 2022 04:43
@0mdc 0mdc force-pushed the gfx-replay-scene-deletion branch from 6ee6be6 to 97b7f49 Compare December 22, 2022 04:44
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

src/esp/gfx/replay/Player.cpp Outdated Show resolved Hide resolved
src/esp/gfx/replay/Recorder.h Outdated Show resolved Hide resolved
@0mdc 0mdc marked this pull request as ready for review December 22, 2022 15:31
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/esp/assets/ResourceManager.cpp Outdated Show resolved Hide resolved
@0mdc 0mdc merged commit 1e58edd into facebookresearch:main Dec 22, 2022
@0mdc 0mdc deleted the gfx-replay-scene-deletion branch June 14, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants