-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gfx-replay: Record scene graph deletions. #1975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Dec 22, 2022
0mdc
force-pushed
the
gfx-replay-scene-deletion
branch
from
December 22, 2022 04:43
73451a3
to
6ee6be6
Compare
0mdc
force-pushed
the
gfx-replay-scene-deletion
branch
from
December 22, 2022 04:44
6ee6be6
to
97b7f49
Compare
…leting scene graphs from gfx-replay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
eundersander
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Skylion007
reviewed
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When the simulator changes scene, the previous scene graph is not deleted. Because
Recorder
relies on scene node deletion to issue deletion entries to gfx-replay, the previous scene is not cleared from the replay renderer.This changeset adds a method to delete all gfx-replay nodes within a scene graph so that the replay renderer can correctly render process scene changes.
How Has This Been Tested
Tested through Python viewer.
Types of changes
Checklist