Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dataset_downloader for HM3D v0.2 #1916

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Cleanup dataset_downloader for HM3D v0.2 #1916

merged 4 commits into from
Oct 27, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Oct 26, 2022

Motivation and Context

Follow-up to #1910 which updated paths for HM3D Semantics v0.2.
As pointed out by @srama2512, some download paths were changed for HM3D's annotated v0.2 scenes which were not correctly updated in the previous PR.

Primary changes:

  • correctly reference v0.2 of non-semantic HM3D.
  • remove obj mtl from habitat downloader (these were not updated with v0.2 and have no reason to be connected to Habitat).
  • clean up uid tags to no longer reference version (like all other data-sources)

How Has This Been Tested

Local testing in progress.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3
correctly reference v0.2 of non-semantic HM3D. remove obj mtl from ha…
b7ed693 
…bitat downloader. clean up uid tags to not refence version.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 26, 2022
@ykarmesh
Copy link
Contributor

I tried adding @srama2512 as a reviewer but I am unable to do that

@aclegg3 aclegg3 merged commit 50776e7 into main Oct 27, 2022
@aclegg3 aclegg3 deleted the hm3d-v0.2 branch October 27, 2022 16:05
@aclegg3 aclegg3 mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykarmesh ykarmesh ykarmesh approved these changes

@devendrachaplot devendrachaplot Awaiting requested review from devendrachaplot

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @ykarmesh @facebook-github-bot