Update Magnum to latest & fix various minor buildsystem issues #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the package can't be built with an external Magnum installation. Plus I don't guarantee forward compatibility for any of these.
facebook-github-bot
added
the
CLA Signed
Nice. |
|
Hmm... "$SRC_DIR/src/esp/bindings/GfxBindings.cpp:15:10: fatal error: 'esp/bindings/EnumOperators.h' file not found" |
|
Lol, sorry. Fixed. |
|
Now clang-format is complaining a bit. |
|
Fixed. (Note to self: don't open PRs at 8 PM.) |
Skylion007
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Changes that aren't really related to the upcoming second batch renderer PR, thus submitting them separately.
Regular update of Magnum submodules:
BoolVector->BitVector, for consistency with newBitArraycontainers and because it's one character less to type)std::hashspecialization forContainers::StringAnd some minor fixes. For faster iterations I'm having a second build directory that uses a system-installed Magnum and has various features disabled, and various code rot prevented that from working:
And finally, certain bindings code used a private header from
magnum-bindings. It's private so I don't guarantee any forward compatibility, I don't want anybody to use it 😝, and it doesn't even get installed which causes a build failure if Magnum is external. I made a copy of that utility directly inside Habiat and the bindings code now uses that instead.How Has This Been Tested
Builds locally.
Types of changes