Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix): remove direct usage of hsim_bindings for audio and fix missing reexports #1788

Merged
merged 3 commits into from
Jun 27, 2022
Merged

(bugfix): remove direct usage of hsim_bindings for audio and fix missing reexports #1788

merged 3 commits into from
Jun 27, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • hsim_bindings is supposed to be a private API as indicated by the underscore. I guess it was used since one of the bindings wasn't properly exported under habitat_sim.sensor. I went ahead and added the missing exports and changed the tutorial accordingly.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 17, 2022
aclegg3
aclegg3 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch.

@Skylion007 Skylion007 merged commit 80f8e31 into main Jun 27, 2022
@Skylion007 Skylion007 deleted the skylion007/fix-audio-tutorial-style branch June 27, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@sanchitgarg sanchitgarg Awaiting requested review from sanchitgarg

@eundersander eundersander Awaiting requested review from eundersander

@ChanganVR ChanganVR Awaiting requested review from ChanganVR

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @aclegg3 @facebook-github-bot