[sl] fix compatibility with PEP 440 #606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We still depend on pointing to the specific Python combination that GitHub CI and Homebrew have, which currently is 3.11.3. Hashes were taken from https://github.com/Homebrew/homebrew-core/blob/d39875e2128e83333aa12728b715fd932c52a1f4/Formula/[email protected] Test plan: CI
Summary: Our current versioning schema isn't compatible with PEP 440. Luckily, changing the last `-` to a ` ` works. Credit for the idea goes to @ZhongRuoyu as mentioned in #598 Test Plan: ci
|
@sggutier has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
Summary: [sl] bump macOS python CI to 3.11.3 We still depend on pointing to the specific Python combination that GitHub CI and Homebrew have, which currently is 3.11.3. Hashes were taken from https://github.com/Homebrew/homebrew-core/blob/d39875e2128e83333aa12728b715fd932c52a1f4/Formula/[email protected] Pull Request resolved: #605 Test Plan: Downloaded bottles from: https://github.com/sggutier/sapling/actions/runs/4727040284 https://github.com/sggutier/sapling/actions/runs/4727040323 and installed the arm64 version. Also, verified that the dumps from `otool -L` looked correct (they usually don't when there is some when building) Dump from arm64 version: ``` $ otool -L sapling\ 8/0.2.20230417-165855 6db1e950/bin/sl && file sapling\ 8/0.2.20230417-165855 6db1e950/bin/sl sapling 8/0.2.20230417-165855 6db1e950/bin/sl: /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3) /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60158.100.133) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1858.112.0) @HOMEBREW_PREFIX@@/opt/[email protected]/lib/libssl.1.1.dylib (compatibility version 1.1.0, current version 1.1.0) @HOMEBREW_PREFIX@@/opt/[email protected]/lib/libcrypto.1.1.dylib (compatibility version 1.1.0, current version 1.1.0) /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1163.100.19) /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11) @HOMEBREW_PREFIX@@/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/Python (compatibility version 3.11.0, current version 3.11.0) sapling 8/0.2.20230417-165855 6db1e950/bin/sl: Mach-O 64-bit executable arm64 ``` Dump from x86 version: ``` $ otool -L sapling\ 9/0.2.20230417-165855 6db1e950/bin/sl && file sapling\ 9/0.2.20230417-165855 6db1e950/bin/sl sapling 9/0.2.20230417-165855 6db1e950/bin/sl: /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3) /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60158.100.133) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1858.112.0) @HOMEBREW_PREFIX@@/opt/[email protected]/lib/libssl.1.1.dylib (compatibility version 1.1.0, current version 1.1.0) @HOMEBREW_PREFIX@@/opt/[email protected]/lib/libcrypto.1.1.dylib (compatibility version 1.1.0, current version 1.1.0) /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1163.100.19) /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11) @HOMEBREW_PREFIX@@/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/Python (compatibility version 3.11.0, current version 3.11.0) sapling 9/0.2.20230417-165855 6db1e950/bin/sl: Mach-O 64-bit executable x86_64 ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/605). * #606 * __->__ #605 Reviewed By: zzl0 Differential Revision: D45072742 Pulled By: sggutier fbshipit-source-id: 4ced2d609d9cf4098cd4bbea5d5df45659588ad8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sl] fix compatibility with PEP 440
Summary:
Our current versioning schema isn't compatible with PEP 440. Luckily, changing the last
-to aCredit for the idea goes to @ZhongRuoyu as mentioned in #598
Test Plan:
ci
Stack created with Sapling. Best reviewed with ReviewStack.