{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":54664770,"defaultBranch":"main","name":"redex","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-03-24T18:26:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1699985801.0","currentOid":""},"activityList":{"items":[{"before":"e904354a796ccd9f73e48ea1f6da22728a3e1a48","after":"c2fc5d9451c6a83c204edabfcf62bf4666bb00ce","ref":"refs/heads/main","pushedAt":"2024-07-24T00:38:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix AM_LOG_FLAGS (#887)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/887\n\n`sh` is not always `bash` (or similar). Modern Debian, for example, uses `dash` - which does not support `source`. Fix the invocation to be POSIX-compliant.\n\nReviewed By: wsanville\n\nDifferential Revision: D60141728\n\nfbshipit-source-id: f939d7164c7b88ee3c5de11d445324fc2386d184","shortMessageHtmlLink":"Fix AM_LOG_FLAGS (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2426239000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/887\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/887/hovercard\" href=\"https://github.com/facebook/redex/pull/887\">#887</a>)"}},{"before":"74587c6912ab6a2278ac68dc9558645d5b5f446f","after":"e904354a796ccd9f73e48ea1f6da22728a3e1a48","ref":"refs/heads/main","pushedAt":"2024-07-23T21:36:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Created functions to perform the testing for the static value inlining for both APK and Bundle\n\nSummary: Created an Impl file that performs the assertions in both the Bundle instance and APK instance based upon prior prepping of the parameters.\n\nReviewed By: wsanville\n\nDifferential Revision: D60123576\n\nfbshipit-source-id: b9c95807bbbc0c6e5999d0a2ba4cd27b0cdbc5c8","shortMessageHtmlLink":"Created functions to perform the testing for the static value inlinin…"}},{"before":"487c88fd765ed9173a3d6a0ef1ccab72d7b9cba0","after":"74587c6912ab6a2278ac68dc9558645d5b5f446f","ref":"refs/heads/main","pushedAt":"2024-07-23T21:05:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix running tests (#885)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/885\n\nTypo in the workflow.\n\nThe test result upload does not work. Remove it for now. Will look for a fancier action for it.\n\nReviewed By: wsanville\n\nDifferential Revision: D60046788\n\nfbshipit-source-id: e3c2c3e3ca6b9ab964acc81f35938063e9ecad7b","shortMessageHtmlLink":"Fix running tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2423281658\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/885\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/885/hovercard\" href=\"https://github.com/facebook/redex/pull/885\">#885</a>)"}},{"before":"d4c9663981253f3ed281dae46bc85a68b63ccbd5","after":"487c88fd765ed9173a3d6a0ef1ccab72d7b9cba0","ref":"refs/heads/main","pushedAt":"2024-07-23T20:46:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Build cache (#886)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/886\n\nThe transition to GA made some mistakes.\n\nThe context data needs to be evaluated as an expression. The `$` was missed, we always used one static literal key.\n\nThe temporary file was used because of CircleCI restrictions on expressions in the cache key, but is the suggested and supported solution because the file hash is computed lazily.\nIn GA, it seems the hash is computed eagerly, *before* the file is actually created. On the other hand, the cache key supports general expression evaluation, so we can move those elements directly to the key.\n\nThe `github.sha` is not the most up-to-date commit in a PR. However, there does not seem to be one simple best key. So leave that as-is for now and hope that it's good enough or fallback works.\n\nNo `restore-keys` have been set to find a less precise cache. Add some.\n\nReviewed By: thezhangwei\n\nDifferential Revision: D60048474\n\nfbshipit-source-id: e00632d0732a091dc23d4b9202940225c599b586","shortMessageHtmlLink":"Build cache (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2423343409\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/886\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/886/hovercard\" href=\"https://github.com/facebook/redex/pull/886\">#886</a>)"}},{"before":"facea3cdab39f620acbced4d32853fd7adc35f49","after":"58ce4d7b7b687e7416731a648fc4123da0f5de93","ref":"refs/heads/stable","pushedAt":"2024-07-23T13:58:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Take the less-equal binary function as a argument in PatriciaTreeCore::leq\n\nSummary:\nWe want to use patricia trees in another tool internally, to improve performance.\nThat tool has an abstract domain interface that has an additional parameter for its `leq` operator.\nUnfortunately, the `leq` operator in sparta is a static method in the `ValueInterface`, which cannot be adapted for that tool.\n\nTo unblock the situation, let's make `PatriciaTreeCore` (the internal class representing patricia tree) accept an arbitrary operator for its `leq` method.\nNote that `PatriciaTreeMap`, `PatriciaTreeMapAbstractEnvironment` and `PatriciaTreeMapAbstractPartition` are unchanged.\n\nWe also expose a `find` method that returns nullptr when the key is not found. This will also be necessary.\n\nReviewed By: arnaudvenet\n\nDifferential Revision: D60052170\n\nfbshipit-source-id: c27eeaef4872fe8d4b9b93409e5017622faf1952","shortMessageHtmlLink":"Take the less-equal binary function as a argument in PatriciaTreeCore…"}},{"before":"55e36c457dc1e237044c316b27cec5b253269cf5","after":"d4c9663981253f3ed281dae46bc85a68b63ccbd5","ref":"refs/heads/main","pushedAt":"2024-07-23T13:57:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Take the less-equal binary function as a argument in PatriciaTreeCore::leq\n\nSummary:\nWe want to use patricia trees in another tool internally, to improve performance.\nThat tool has an abstract domain interface that has an additional parameter for its `leq` operator.\nUnfortunately, the `leq` operator in sparta is a static method in the `ValueInterface`, which cannot be adapted for that tool.\n\nTo unblock the situation, let's make `PatriciaTreeCore` (the internal class representing patricia tree) accept an arbitrary operator for its `leq` method.\nNote that `PatriciaTreeMap`, `PatriciaTreeMapAbstractEnvironment` and `PatriciaTreeMapAbstractPartition` are unchanged.\n\nWe also expose a `find` method that returns nullptr when the key is not found. This will also be necessary.\n\nReviewed By: arnaudvenet\n\nDifferential Revision: D60052170\n\nfbshipit-source-id: c27eeaef4872fe8d4b9b93409e5017622faf1952","shortMessageHtmlLink":"Take the less-equal binary function as a argument in PatriciaTreeCore…"}},{"before":"65831d74e613b7b1682853c58b6816d74455acda","after":"55e36c457dc1e237044c316b27cec5b253269cf5","ref":"refs/heads/main","pushedAt":"2024-07-23T00:51:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add arithmetic reductions for longs\n\nSummary:\nAdds arithmetic reductions for long values. Logic is roughly the same as with ints.\n\nAlso adds tests.\n\nReviewed By: NTillmann\n\nDifferential Revision: D59884232\n\nfbshipit-source-id: b0f4d5c49b54dd19dc706a420e3dae00a62f44f8","shortMessageHtmlLink":"Add arithmetic reductions for longs"}},{"before":"7035cd2e1b8e2ee704a866d7852997194d4ca06f","after":"65831d74e613b7b1682853c58b6816d74455acda","ref":"refs/heads/main","pushedAt":"2024-07-22T20:30:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use `get_env` helper\n\nSummary: Use a helper with null check. Improve diagnostics of not properly wired up tests.\n\nReviewed By: wsanville\n\nDifferential Revision: D60045296\n\nfbshipit-source-id: f31740df3963e58a84ce1c3f2a43c2dbac11a808","shortMessageHtmlLink":"Use <code>get_env</code> helper"}},{"before":"5c57a8de88264abd3ac7fa287580961c45eff4ee","after":"7035cd2e1b8e2ee704a866d7852997194d4ca06f","ref":"refs/heads/main","pushedAt":"2024-07-22T19:18:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove secondary profiles\n\nSummary: Unused, not planned to be revived.\n\nReviewed By: jimmycFB\n\nDifferential Revision: D59526137\n\nfbshipit-source-id: eac12338822e6aba37b6ad0b706c46f761208ea4","shortMessageHtmlLink":"Remove secondary profiles"}},{"before":"01d464db810dbfd1b50c4d1c75747579328f4607","after":"facea3cdab39f620acbced4d32853fd7adc35f49","ref":"refs/heads/stable","pushedAt":"2024-07-22T19:18:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove secondary profiles\n\nSummary: Unused, not planned to be revived.\n\nReviewed By: jimmycFB\n\nDifferential Revision: D59526137\n\nfbshipit-source-id: eac12338822e6aba37b6ad0b706c46f761208ea4","shortMessageHtmlLink":"Remove secondary profiles"}},{"before":"e37239598ccc3001299308a5dd4e435616b377cc","after":"5c57a8de88264abd3ac7fa287580961c45eff4ee","ref":"refs/heads/main","pushedAt":"2024-07-22T17:27:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"regression test\n\nReviewed By: agampe, ssj933\n\nDifferential Revision: D59989093\n\nfbshipit-source-id: 3047dabcb70a18d2b6f55ec3e2c53fce4c7448c3","shortMessageHtmlLink":"regression test"}},{"before":"f8a1e5354d77b039ee08ede560f2034e54fa9db0","after":"01d464db810dbfd1b50c4d1c75747579328f4607","ref":"refs/heads/stable","pushedAt":"2024-07-22T17:26:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"regression test\n\nReviewed By: agampe, ssj933\n\nDifferential Revision: D59989093\n\nfbshipit-source-id: 3047dabcb70a18d2b6f55ec3e2c53fce4c7448c3","shortMessageHtmlLink":"regression test"}},{"before":"8c8d7d0b269cebf435ed7b4447745092332e0e4f","after":"e37239598ccc3001299308a5dd4e435616b377cc","ref":"refs/heads/main","pushedAt":"2024-07-20T04:11:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a way to define test-specific env variables (#883)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/883\n\nIf a test needs specific env variables set, it can provide a file named `{test}.env` that will be sourced before running the test. It is expected to contain exports to change the environment.\n\nReviewed By: wsanville\n\nDifferential Revision: D59949070\n\nfbshipit-source-id: 2270ac62ad45e4c19c2ece49a1532e70de1ecd8c","shortMessageHtmlLink":"Add a way to define test-specific env variables (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2420311453\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/883\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/883/hovercard\" href=\"https://github.com/facebook/redex/pull/883\">#883</a>)"}},{"before":"955dbdef625e1867f37c0344bdb790b9a215de5f","after":"8c8d7d0b269cebf435ed7b4447745092332e0e4f","ref":"refs/heads/main","pushedAt":"2024-07-19T21:40:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix LOG_COMPILER (#882)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/882\n\nDo not trust Google results...\n\nThe actual invoke must \"quote\" dollar signs for correct invocation.\n\nReviewed By: wsanville\n\nDifferential Revision: D59931827\n\nfbshipit-source-id: e43f7c14654a81fc23e48f13f48981ac23a314d8","shortMessageHtmlLink":"Fix LOG_COMPILER (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2419691129\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/882\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/882/hovercard\" href=\"https://github.com/facebook/redex/pull/882\">#882</a>)"}},{"before":"0fd72092b819dc598da14ffaeecbf60892316818","after":"955dbdef625e1867f37c0344bdb790b9a215de5f","ref":"refs/heads/main","pushedAt":"2024-07-19T18:54:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"to check if there is invoke-virtual on allowed API's before running analyzer\n\nSummary: Before actually running the static analysis on the control flow graph, checking of there is an invoke-virtual operation done on one of the allowed API's. If there is no such operation, saving the expensive cost of running the static analyzer and replaying altogether.\n\nReviewed By: wsanville\n\nDifferential Revision: D59940396\n\nfbshipit-source-id: 1093707795caa81e991dc3eef3cf3a5a7dc74ac8","shortMessageHtmlLink":"to check if there is invoke-virtual on allowed API's before running a…"}},{"before":"628d6e2beb41d13e8d1abb09222725c8012e795e","after":"f8a1e5354d77b039ee08ede560f2034e54fa9db0","ref":"refs/heads/stable","pushedAt":"2024-07-19T18:46:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixing substitute_stats\n\nReviewed By: wsanville\n\nDifferential Revision: D59942722\n\nfbshipit-source-id: c4e7844b1227c79df58a86a57e4aac7322b156f3","shortMessageHtmlLink":"Fixing substitute_stats"}},{"before":"a85299feeca47aecef8df0efa69e72e0e5dc43a8","after":"0fd72092b819dc598da14ffaeecbf60892316818","ref":"refs/heads/main","pushedAt":"2024-07-19T04:08:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix LOG_COMPILER (#881)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/881\n\nDo not trust Google results...\n\nThe actual invoke must \"quote\" dollar signs for correct invocation.\n\nDisable tests that are actually failing.\n\nOne test is recovered when copying the SDK setup from unit tests.\n\nReviewed By: wsanville\n\nDifferential Revision: D59930260\n\nfbshipit-source-id: ae298b3454b7eae42d6e3569a71a2b26809bef8d","shortMessageHtmlLink":"Fix LOG_COMPILER (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2417596131\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/881\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/881/hovercard\" href=\"https://github.com/facebook/redex/pull/881\">#881</a>)"}},{"before":"2b6aa8570f81a6eba3a5d6d0b6e02626025dc617","after":"a85299feeca47aecef8df0efa69e72e0e5dc43a8","ref":"refs/heads/main","pushedAt":"2024-07-19T02:24:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Filter inlinable values based on allowed types/entries in pass config\n\nSummary: Using the sets defined in D58442548 for allowed resource type names and allowed resource entries for inlining in the bind_config() method to filter the return value from D59036402 to only operate on allowed types/entries.\n\nReviewed By: wsanville\n\nDifferential Revision: D59889855\n\nfbshipit-source-id: cecc509cbb0e75843dbb018437c547510eafbc91","shortMessageHtmlLink":"Filter inlinable values based on allowed types/entries in pass config"}},{"before":"f9fd8b9fd965afdaa5d66f487e1afac709ac3d78","after":"2b6aa8570f81a6eba3a5d6d0b6e02626025dc617","ref":"refs/heads/main","pushedAt":"2024-07-19T00:50:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable building two sample apps (#880)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/880\n\nThis may enable more unit tests in the future.\n\nReviewed By: wsanville\n\nDifferential Revision: D59845191\n\nfbshipit-source-id: e7459768bce04cc68c8191ce9d4e814dc91f8ec2","shortMessageHtmlLink":"Enable building two sample apps (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2414980125\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/880\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/880/hovercard\" href=\"https://github.com/facebook/redex/pull/880\">#880</a>)"}},{"before":"5b49a8908f7bf036ac1053dd687d2adcd2c32d49","after":"f9fd8b9fd965afdaa5d66f487e1afac709ac3d78","ref":"refs/heads/main","pushedAt":"2024-07-19T00:40:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixing substitute_stats\n\nReviewed By: ssj933\n\nDifferential Revision: D59871903\n\nfbshipit-source-id: 15449dd0f34f53501698ff8f37c5306a85449bc4","shortMessageHtmlLink":"Fixing substitute_stats"}},{"before":"e67fd9235ad41ae3e1a6805477516b830ade141b","after":"5b49a8908f7bf036ac1053dd687d2adcd2c32d49","ref":"refs/heads/main","pushedAt":"2024-07-18T23:44:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove some unnecessary .h includes\n\nReviewed By: agampe\n\nDifferential Revision: D59870259\n\nfbshipit-source-id: 8b10a1ec71d4a2fa6366ef3ba8f058d6903e42f5","shortMessageHtmlLink":"Remove some unnecessary .h includes"}},{"before":"f21edd2a87cf16eecc3f06e57ccac6470324e2b1","after":"e67fd9235ad41ae3e1a6805477516b830ade141b","ref":"refs/heads/main","pushedAt":"2024-07-18T21:02:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"target_version should be android-29\n\nSummary: Needs to be qualified.\n\nReviewed By: wsanville\n\nDifferential Revision: D59930261\n\nfbshipit-source-id: 6d8bfdadb207509bd1dc615b612ec384b3a01634","shortMessageHtmlLink":"target_version should be android-29"}},{"before":"242dccb83618f3b052592989759a566afcb647a3","after":"f21edd2a87cf16eecc3f06e57ccac6470324e2b1","ref":"refs/heads/main","pushedAt":"2024-07-17T23:35:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable two unit tests (#879)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/879\n\nAs title\n\nReviewed By: wsanville\n\nDifferential Revision: D59727138\n\nfbshipit-source-id: bd6a166cfb53213514b90315485d2ac848535860","shortMessageHtmlLink":"Enable two unit tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2414596394\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/879\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/879/hovercard\" href=\"https://github.com/facebook/redex/pull/879\">#879</a>)"}},{"before":"9d683c7c6ddcc711858fe60726a0cf6b43cda7c4","after":"628d6e2beb41d13e8d1abb09222725c8012e795e","ref":"refs/heads/stable","pushedAt":"2024-07-17T23:21:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Be careful with char*\n\nSummary: As title.\n\nReviewed By: wsanville\n\nDifferential Revision: D59873720\n\nfbshipit-source-id: b278f5ec46d4c81cd8a113ff276f7bc44291996b","shortMessageHtmlLink":"Be careful with char*"}},{"before":"01dbc502ef87434e5621d7a007553e43268f2afd","after":"242dccb83618f3b052592989759a566afcb647a3","ref":"refs/heads/main","pushedAt":"2024-07-17T23:19:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Be careful with char*\n\nSummary: As title.\n\nReviewed By: wsanville\n\nDifferential Revision: D59873720\n\nfbshipit-source-id: b278f5ec46d4c81cd8a113ff276f7bc44291996b","shortMessageHtmlLink":"Be careful with char*"}},{"before":"9c089ee4571682dbc8a3162477438d842e5f4889","after":"01dbc502ef87434e5621d7a007553e43268f2afd","ref":"refs/heads/main","pushedAt":"2024-07-17T20:18:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Exempted Open Source Build\" (#878)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/878\n\nOriginal commit changeset: 3eca2dfc544c\n\nOriginal Phabricator Diff: D59476625\n\nReviewed By: wsanville\n\nDifferential Revision: D59561230\n\nfbshipit-source-id: 11bbf37085a68bb9ca72cc09106ae6a30737ba2c","shortMessageHtmlLink":"Back out \"Exempted Open Source Build\" (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2414065660\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/878\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/878/hovercard\" href=\"https://github.com/facebook/redex/pull/878\">#878</a>)"}},{"before":"a8c968839a276674078adf99b53a8c7dc0ccbaed","after":"9c089ee4571682dbc8a3162477438d842e5f4889","ref":"refs/heads/main","pushedAt":"2024-07-16T22:00:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"`m_` cleanup\n\nSummary:\n`m_` fields should always be non-public.\nThis is a behavior-preserving refactoring.\n\nReviewed By: beicy\n\nDifferential Revision: D59819188\n\nfbshipit-source-id: baafa683d0c4948e43467d695d6d9ec9a27eca3b","shortMessageHtmlLink":"<code>m_</code> cleanup"}},{"before":"003567216867dbbd7b9d04d1c88f55aad5c040d8","after":"9d683c7c6ddcc711858fe60726a0cf6b43cda7c4","ref":"refs/heads/stable","pushedAt":"2024-07-16T21:11:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Promote \"Write failed methods to file\"\n\nSummary: Promote {D59758479}.\n\nReviewed By: danjin250\n\nDifferential Revision: D59765270\n\nfbshipit-source-id: f6787872962fee0efb6523d26629fe4e30d77305","shortMessageHtmlLink":"Promote \"Write failed methods to file\""}},{"before":"7615c448ca429d4b9e0cb67adde1b2ec0162362c","after":"a8c968839a276674078adf99b53a8c7dc0ccbaed","ref":"refs/heads/main","pushedAt":"2024-07-16T21:09:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"refactoring\n\nSummary: This is a behavior-preserving change that decouples the inner method splitting logic from the MethodSplittingPass.\n\nReviewed By: wsanville\n\nDifferential Revision: D59354940\n\nfbshipit-source-id: e91f824890422d34416b8210885be9df0b636294","shortMessageHtmlLink":"refactoring"}},{"before":"2d0a4187d6977760735c9afe9886e79a593cd315","after":"7615c448ca429d4b9e0cb67adde1b2ec0162362c","ref":"refs/heads/main","pushedAt":"2024-07-16T18:54:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Added cases to ensure program behavior at runtime is not changed\n\nSummary:\nTwo additional cases were added to ResourcesInliningPass.cpp and test cases added to the java file:\n1. Removing any invokes that are never actually used\n2. Not altering the program behavior: if the program would have crashed initially, ensuring that we are not inlining in such a way that it is now successful.\n\nReviewed By: wsanville\n\nDifferential Revision: D59764754\n\nfbshipit-source-id: df0eaf35b18e0748b56786ecb63aa8fbff185956","shortMessageHtmlLink":"Added cases to ensure program behavior at runtime is not changed"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEh2dh0gA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/redex"}