Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep @memlab/* versions in lockstep in package.json #113

Closed
jeswr opened this issue Feb 11, 2024 · 1 comment
Closed

Keep @memlab/* versions in lockstep in package.json #113

jeswr opened this issue Feb 11, 2024 · 1 comment

Comments

@jeswr
Copy link

jeswr commented Feb 11, 2024 •
edited
Loading

I've recently encountered the error core_1.browserInfo.recordPuppeteerConfig is not a function. This is similar to #109; and it was encountered in an automated dependabot update (eyereasoner/eye-js#831).

Indeed running npm upgrade to bump the version of @memlab/core fixes the issue; but really I would expect that if @memlab/api uses APIs introduced in v1.1.27 of @memlab/core then @memlab/api should depend on at minimum ^1.1.27 of @memlab/core in the package.json as opposed to v1.1.10 which it is currently set at

memlab/packages/api/package.json

Lines 30 to 32 in bb1a3b6

"@memlab/core": "^1.1.10",
"@memlab/e2e": "^1.0.9",
"@memlab/heap-analysis": "^1.0.7",
as this would then ensure that tooling like npm and dependabot will upgrade such dependencies in downstream lockfiles when trying to upgrade the version of @memlab/api.

Monorepo tooling such as lerna has native support for this kind of lockstep versioning.
@JacksonGL
Copy link
Member

JacksonGL commented Feb 11, 2024 •
edited
Loading

Thank you for reporting this issue. I have updated the minimum version of dependency and published the latest version ([email protected]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JacksonGL @jeswr