Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan screen rotation #149

Closed
vinsentli opened this issue Jul 10, 2024 · 5 comments
Closed

vulkan screen rotation #149

vinsentli opened this issue Jul 10, 2024 · 5 comments
Assignees
@pixelperfect3

Comments

@vinsentli
Copy link
Contributor

There are two questions about switching landscape and portrait mode on vulkan:

  1. After opening the app, when rendering vulkan, switch landscape and portrait mode will cause a crash.
  2. On a landscape mode screen pad, open the app in portrait mode. The content displayed by vulkan is wrong, as shown in the picture below. Its image is rotated 90 degrees clockwise.
OpenGLES Vulkan
Landscape mode Screenshot_20240710_121608_IGL Screenshot_20240710_121621_IGL
Portrait mode Screenshot_20240710_121634_IGL [Wrong]Screenshot_20240710_121646_IGL
@fcoulombe
Copy link

fcoulombe commented Jul 10, 2024 •
edited
Loading

#thanks for reporting this.

It looks like you're running on a mobile phone. Can you please specify how did you go about building and running the application?

@vinsentli
Copy link
Contributor Author

@fcoulombe
My pad is set to default landscape mode, and when I run it in portrait mode, this issue occurs.

Screen_Recording_20240710_165854_IGL.mp4

@pixelperfect3
Copy link

Could you specify which device you are testing on and how you are running the app?

@vinsentli
Copy link
Contributor Author

vinsentli commented Jul 12, 2024 •
edited
Loading

Could you specify which device you are testing on and how you are running the app?

@pixelperfect3
My device is Samsung Galaxy Tab S7  .

My pad main work mode is landscape mode. when I switch to portrait mode,lanuch the app, this issue occurs.

You can watch the video above.

@vinsentli
Copy link
Contributor Author

vinsentli commented Aug 1, 2024 •
edited
Loading

@corporateshark @pixelperfect3
Is there any progress on this issue ？

@vinsentli vinsentli mentioned this issue Aug 27, 2024
Closed
facebook-github-bot pushed a commit that referenced this issue Sep 4, 2024
@vinsentli @facebook-github-bot
igl | shell | vulkan | Support screen rotate on android (#168)
c30feef 
Summary:
Reference : https://android-developers.googleblog.com/2020/02/handling-device-orientation-efficiently.html

This is the solution for #149

https://github.com/user-attachments/assets/e55a9cd3-a462-4894-89a2-fb17ba31557b

Pull Request resolved: #168

Reviewed By: mmaurer

Differential Revision: D62017423

Pulled By: rokuz

fbshipit-source-id: b87d62bc967f5a306418a789ce1a6cbe68c4d353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelperfect3 pixelperfect3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pixelperfect3 @fcoulombe @vinsentli @francoiscoulombe