-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precompiled hermes binaries? #17
Comments
We already provide binaries for macOS, Linux and Windows (all x86_64) through GitHub releases and NPM. Is that what you're looking for, or do you have other platforms in mind? |
That's helpful, thanks! GoogleChromeLabs/jsvu#74 adds
If any of these assumptions seem likely to change in the future, please let us know so we can come up with an alternate approach. |
Along the way, I noticed that the npm tarballs (e.g. https://registry.npmjs.org/hermesvm/-/hermesvm-0.1.0.tgz) do not contain the DLLs for the Windows version. The GitHub tarballs do. Let me know if you'd like me to file this as a separate issue. |
Hey just noticed that the tools from https://github.com/facebook/hermes/blob/master/doc/BuildingAndRunning.md#other-tools are not included in the prebuilt binaries. Would be awesome if you could add them to a release 😄 |
@mathiasbynens Thanks for noticing! This issue is fine. |
The NPM ICU dll issue was fixed in 02ec02a, though it still depends on the MSVC 2015 Redistributable though. All future NPM releases should include them, as well as the precompiled binaries. |
Summary: Treat `static_ref_cast<JFoo>` as equivalent to `static_ref_cast<JniType<JFoo>>`, which is equivalent to `static_ref_cast<JFoo::javaobject>`. As a side-effect, this also allows `JMap<JFoo, JFoo>`, since the only thing blocking that before was a cast. Pull Request resolved: facebookincubator/fbjni#17 Test Plan: CI Reviewed By: cjhopman Differential Revision: D18121225 Pulled By: dreiss fbshipit-source-id: 81d0d56967dcb8d907d3a3cec4a52e110743853c
Hey y'all,
Congrats on open-sourcing Hermes!
Are you planning on providing precompiled
hermes
binaries for various platforms? If you are, we'd be happy to addhermes
support tojsvu
. This would make it easier for folks to casually play around with a recenthermes
binary without having to clone sync build from source every time.If not, that's cool too. Figured I'd ask :)
Cheers,
Mathias
The text was updated successfully, but these errors were encountered: