Require unique model_key in GenerationNode, clean up model selection errors #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors Summary: Updates GNode to require a unique model_key for each of its ModelSpecs. This will make sure we can identify the model used for generating a trial from the model_key attribute on GR, in case two models based on same registry entry are used (e.g., MBM). Also updates some of the old error messages related to BestModelSelector. Differential Revision: D62029739
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62029739 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2730 /- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 490 490
Lines 47872 47874 2
=======================================
Hits 45681 45683 2
Misses 2191 2191 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates GNode to require a unique model_key for each of its ModelSpecs. This will make sure we can identify the model used for generating a trial from the model_key attribute on GR, in case two models based on same registry entry are used (e.g., MBM).
Also updates some of the old error messages related to BestModelSelector.
Differential Revision: D62029739