Merge create_single_objective_problem_from_botorch and create_multi_objective_problem_from_botorch; support constrained MOO #2722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: These functions have a lot of overlapping functionality. Combining them makes it easier to extend their functionality (for example, by supporting constrained MOO).
This PR:
create_single_problem_objective_from_botorch
andcreate_multi_objective_problem_from_botorch
intocreate_problem_from_botorch
lower_is_better
off the test problem -- BoTorch test problems assume minimization unlessnegate
is set to True -- instead of requiring the user to pass it (multi-objective problems used to always have lower_is_better=True, so this is more accurate and prevents mismatch)Differential Revision: D61877865