Graph: Supporting custom functions for node rendering; onRenderComplete callback #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokotyan
force-pushed
the
graph/custom-rendering
branch
2 times, most recently
from
10ff245
to
e6c07c2
Compare
reb-dev
reviewed
Jul 9, 2024
|
Do we need to add documentation for this? |
|
@lee00678 Yes, definitely. And probably a new example. I feel like it's a pretty big feature so we might want to present it properly. |
rokotyan
force-pushed
the
graph/custom-rendering
branch
from
e6c07c2
to
f7792e7
Compare
…he rendering functions
- `pathLength` can be 0 and we need to handle that - `flowGroup` opacity should be updated on zoom
- New Config property: `nodeSelectionHighlightMode` to control what to dim / highlight on node selection - Fix: Node and link state was set after render - Refactor: Removed unnecessary render calls - Refactor: Renamed state-related rendering functions (updateNodesPartial, updateLinksPartial)
rokotyan
force-pushed
the
graph/custom-rendering
branch
from
edab85f
to
af15c32
Compare
|
Latest commits summary: Reworking node selection and state update logic
|
|
@reb-dev (cc @lee00678) After some more local testing, I think I need to make the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the users to come up with their own node rendering functions, which will be a pretty common use case for everyone designing their own graphs.
It also add the
onRenderCompletecallback which allows you to do even more, e.g. add custom background / foreground graphics.Screen.Recording.2024-06-20.at.3.32.51.PM.mp4