Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auto] Update Rust toolchain to 1.79.0 #145

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[auto] Update Rust toolchain to 1.79.0 #145

merged 1 commit into from
Jun 14, 2024

Conversation

expressvpn-iat-bot
Copy link
Collaborator

@github-actions GitHub Actions
Copy link

Code coverage summary for b74b2e4:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                     5                 0   100.00%           2                 0   100.00%          24                 0   100.00%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          14                 2    85.71%           5                 0   100.00%          95                 2    97.89%           0                 0         -
wolfssl/src/context.rs                   166                83    50.00%          46                14    69.57%         349               124    64.47%           0                 0         -
wolfssl/src/error.rs                      22                10    54.55%           7                 3    57.14%          52                10    80.77%           0                 0         -
wolfssl/src/lib.rs                        63                10    84.13%          14                 2    85.71%          84                13    84.52%           0                 0         -
wolfssl/src/rng.rs                        19                 5    73.68%           4                 0   100.00%          47                 3    93.62%           0                 0         -
wolfssl/src/ssl.rs                       475               203    57.26%          82                25    69.51%        1066               277    74.02%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    764               313    59.03%         160                44    72.50%        1717               429    75.01%           0                 0         -

✅ Region coverage 59% passes
✅ Line coverage 75% passes

@kp-mariappan-ramasamy
Copy link
Contributor

Notable changes:

Need to check whether third point impacts us. Other change looks fine

@xv-ian-c
Copy link
Contributor

CI has passed so I think the lib.name thing is ok here. The issue is with setting lib.name but we don't set that, we set package.name and cargo derives lib.name from it and already does the conversion.

If it affected us it would affect wolfssl-sys and/or wolfssls use of it, but wolfssl builds and passes tests.

@xv-ian-c xv-ian-c merged commit 38d2e29 into main Jun 14, 2024
8 checks passed
@xv-ian-c xv-ian-c deleted the gha/rust-toolchain-update branch June 14, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xv-ian-c xv-ian-c xv-ian-c approved these changes

@xv-pete-m xv-pete-m Awaiting requested review from xv-pete-m

@expressvpn-brendan-h expressvpn-brendan-h Awaiting requested review from expressvpn-brendan-h

@kp-mariappan-ramasamy kp-mariappan-ramasamy Awaiting requested review from kp-mariappan-ramasamy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@expressvpn-iat-bot @kp-mariappan-ramasamy @xv-ian-c