-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more PyData theme colors for badges #215
Comments
Looks like there are three undocumented colors: sphinx-design/sphinx_design/shared.py Lines 19 to 31 in 0b178a9
Here's what all the colors look like (including undocumented ones) with the light and dark PyData theme applied: Based on this it looks like So, at the very least, this issue is a documentation issue. It would be good to update the docs to include the three undocumented colors |
Context
I have found that the existing
dark
andlight
colors have low-contrast when viewing a site with the dark and light themes applied, respectively, and are therefore hard to see/read. E.g. see this badge :from pyvista/pyvista#6475.
I went looking for an alternative, but found that
dark
andlight
are the only grayscale options with outlines supported by Sphinx Design: https://sphinx-design.readthedocs.io/en/latest/badges_buttons.htmlProposal
Additional colors are available from the PyData theme:
https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/styling.html#color-variables
Something like the
surface
andon-surface
colors might be good alternatives since these change with the theme.Perhaps all the other PyData theme colors could be supported as well.
Tasks and updates
No response
The text was updated successfully, but these errors were encountered: