Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome import interfering with Pro License #174

Open
kathatherine opened this issue Dec 18, 2023 · 1 comment
Open

FontAwesome import interfering with Pro License #174

kathatherine opened this issue Dec 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kathatherine
Copy link

Context

I'm unsure if this should be requested as a bug or feature request, but as far as we can tell, the sphinx-design free import of FontAwesome is interfering with the Pro tier icons our docs are importing from the FontAwesome CDN. I expected our Pro icons to load, but hey are instead being overlaid with a "missing" class. If you remove the class, the icon appears properly on the page.

We import our CDN by adding a FontAwesome kit script to the head of our docs via a _templates/layout.html page. We attempted to add the same .js file via html_js_files in the conf.py instead, as maybe a way to try and override yours, but the icons still error.

image

image

The commented out HTML is what should actually be there.

Proposal

We're wondering if there's any way to override your free license with our Pro license or turn off your FontAwesome import so it no longer interferes with ours, whether we're missing something from the docs or this requires a feature implementation. We're going to replace the styles of the erroring icons so they aren't Pro icons as a stopgap measure, but you can see one of the pages where the erroring was occurring here: https://docs.anaconda.com/business/cloud/channels/

Tasks and updates

No response

@kathatherine kathatherine added the enhancement New feature or request label Dec 18, 2023
Copy link

welcome bot commented Dec 18, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant