-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 MAINT: fix pre-commit #123
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Let me know if you'd like me to redo the commit messages with emoji! https://github.com/executablebooks/.github/blob/master/CONTRIBUTING.md#commit-messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into these problems as well and I think this is a good fix.
ah I missed this PR, thanks very much @hugovk and thanks @sappelhoff for the ping which made me realize this PR was here :-) |
You're welcome, thank you for this helpful tool (and all the others too)! |
The CI is failing, for example:
The first commit here updates the pre-commit pin to the latest 2.12.1. (Perhaps even unpin this?)
Next, when running pre-commit, it warns:
The second commit runs
pre-commit autoupdate
to update both Black and pre-commit-hooks.Next, pre-commit-hooks errors due to the Flake8 hook having been moved:
The third commit updates the hooks so it uses Flake8 from its new home at https://github.com/PyCQA/flake8.
Finally, 4th commit: we don't need to explicitly install Black and Flake8 into the environment for them to be used by pre-commit. In fact, it's unnecessary because pre-commit manages its own dependencies.