Improve directive block parsing #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #55
Firstly, the
directive block text -> arguments, options, bodyparsing has been separated into to a standalone module.Secondly, the docutils parser here
does not rigidly specify the structure of the directive block:
Instead, if no required/optional arguments are specified (by the directive class), and no
<option block>is used, the<body>block can start at<arguments>. Example:This PR allows MyST to implement that logic.
Note the rST parser also allows for the options to start on the argument line.
But this PR does not implement that, because it doesn't integrate particularly well with the concept of YAML blocks.
Example: