Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rst tables comparison #34

Merged
merged 1 commit into from
Feb 14, 2020
Merged

adding rst tables comparison #34

merged 1 commit into from
Feb 14, 2020

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Feb 14, 2020

This adds a few tables in the syntax page to compare one vs the other...what do folks think? Good way to compare?

@choldgraf
Copy link
Member Author

Here's how one of them looks - I'm not a huge fan of the CSS but I do think the layout is useful: https://49-240151150-gh.circle-artifacts.com/0/html/syntax.html#extra-markdown-syntax

@chrisjsewell
Copy link
Member

Quick question first, how to you find out the links for CircleCI build artifacts?

@chrisjsewell
Copy link
Member

Looks good to me though 👍

@choldgraf
Copy link
Member Author

Mostly, click on the circle link, go to "Artifacts", then click index.html from the dropdown list. You may need CircleCI permissions for this though - let me know if I need to add you or something.

There are also a few bots that will auto-post a link to the documentation alongside your CircleCI link...I'll set that up at some point, just havne't gotten around to it. E.g.:

https://github.com/larsoner/circleci-artifacts-redirector-action

@chrisjsewell
Copy link
Member

I can't see any "Artifacts" section?

image

@choldgraf
Copy link
Member Author

Hmmm - it looks like you may not be logged in with your CircleCI account. Can you make sure it is connected w/ your GitHub account, and that you're logged in, and try again?

@chrisjsewell
Copy link
Member

Sorted ta, for some reason I had to log out and log back in, and now it is showing up

@choldgraf choldgraf merged commit 30ebd98 into develop Feb 14, 2020
@choldgraf choldgraf deleted the rst_compare branch February 14, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants