Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding inter-doc links and more explanation of tokens #22

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

choldgraf
Copy link
Member

No description provided.

@chrisjsewell
Copy link
Member

@choldgraf you missed that LineComments are an extension

@chrisjsewell
Copy link
Member

Also AutoLinks are not an extension

@choldgraf choldgraf force-pushed the docs_improve branch 2 times, most recently from 9c23df2 to 77530fe Compare February 13, 2020 22:50
@choldgraf
Copy link
Member Author

Nice - good catch. Fixed both in the latest push

Something I just realized is that this PR will remove some information from the docs, which is the order of precedence for the extended syntax and the commonmark syntax. Can you think of a good place to insert that information back in here? I do think it's more valuable to explicitly highlight which syntax is new vs. standard...

@choldgraf
Copy link
Member Author

(depending on how you wanna resolve my last question, this PR is ready to go from me, but if you'd like me to add back in "precedence" information somehow (maybe a link in the code for where precedence is defined?) I'm happy to do so

@chrisjsewell
Copy link
Member

I’ll do this in a bit, just adding a FrontMatter token 😄

@choldgraf
Copy link
Member Author

@chrisjsewell I just rebased on develop and added in an internal ref for the frontmatter section 👍

@chrisjsewell
Copy link
Member

Just added a quick commit here, because I'm too lazy to do my own PR

@choldgraf
Copy link
Member Author

heh sounds good - ready to merge if tests are happy? If so then I will squash and merge because I'm not an animal.

@choldgraf
Copy link
Member Author

@chrisjsewell btw - how do you feel about just only allowing squash merge for a bit?

@chrisjsewell
Copy link
Member

Yeh sounds good to me 👍

@choldgraf choldgraf merged commit 2b6e9d4 into develop Feb 14, 2020
@choldgraf choldgraf deleted the docs_improve branch February 14, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants