Exclude Infinity on createInputStream #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Character such as `6E10000` becomes Infinity with `Number()` but it's not `NaN`, so just returns it. It causes error for excel file so can't open generated file. We need to check if it's Infinity or not.
|
@sophiedophie thanks for the pull request :), could I ask you to write a test that covers this change? |
|
@Siemienik Added the test. Please take a look for it and let me know if something need to be improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Character such as
6E10000becomes Infinity withNumber()but it's not
NaN, so just returns it.It causes error for excel file so can't open generated file.
We need to check if it's Infinity or not.