Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1676 #1701

Merged
merged 13 commits into from
Nov 21, 2021
Merged

fix issue 1676 #1701

merged 13 commits into from
Nov 21, 2021

Conversation

skypesky
Copy link
Contributor

@skypesky skypesky commented May 6, 2021

Summary

Fix issue #1676 Broken internal link on Google sheets.
Let hyperlink support internal link.

Test plan

I need to know how to test, thanks.

Related to source code (for typings update)

Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case to cement this approach?

@skypesky
Copy link
Contributor Author

@Siemienik Unit tests have been added. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants