Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1677

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Update README.md #1677

merged 3 commits into from
Nov 18, 2021

Conversation

xjrcode
Copy link
Contributor

@xjrcode xjrcode commented Apr 20, 2021

Added note about internationalized formula semantic

Summary

Test plan

Related to source code (for typings update)

@xjrcode
Update README.md
63007c5 
Added note about internationalized formula semantic
Siemienik
Siemienik reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that useful note 👍

One patch fix and I'll merge it.

README.md Outdated Show resolved Hide resolved
@Siemienik
Copy link
Member

LGTM thank you🙏

@Siemienik Siemienik merged commit dc45ddf into exceljs:master Nov 18, 2021
@j-mendez j-mendez mentioned this pull request Sep 8, 2024
Open
@Vishwas1 Vishwas1 mentioned this pull request Sep 8, 2024
Open
@j-mendez j-mendez mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjrcode @Siemienik