Refine typing for Column #1488
Merged
Refine typing for Column #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_header, _key and width are dependent on defn and therefore may be undefined. Add comment for properties that are dependent on style. Since style will be set to an empty object when defn is not provided, these properties may be undefined as well. Change references of Partial<Column> to Column since the undefined properties are directly handled inside the Column type definition.
|
Partial column thing should be there because now it's giving error. I don't want to define |
|
Fixed by Hesamp in 4e38ad8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to refine the type definition for
Column. This should resolve #1120Test plan
I derived this by looking at
column.js. Then I replacedindex.d.tsinnode_modules/exceljswith my changes and the typescript issue from #1120 went away.