Merge cells after row insert #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@curtcommander @Siemienik does this also cover a case where merged cells below rows which have been inserted also exhibit the same behaviour (value of merged cell gets applied to all cells)? As this is a bit of a blocker currently - using pre-existing excel files as a template and editing them using excelJS, but the data preservation goes out the window on merged cells when I do :( |
|
@calumpeak Which version of exceljs are you using? The current latest version (4.2.0) preserves merges below rows that have been inserted, whereas 4.1.0 does not. I just tested this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merges aren't preserved when cells containing merges get overwritten after row inserts. Instead, the value of a merged cell gets applied to all cells in the merge separately.
becomes
This is because the values for the previously merged cells are pulled from the source row (
rSrc.valuesinspliceRows). The source row's values repeat the merged value for each cell in the merge. For example, the source row values for the row in the first table would be["merged cell text", "merged cell text"]. These values are what gets applied to the cells in the destination row (rDst), and the merge is lost.The extra lines I wrote in
spliceRowsto fix this reapply merges to cells while accounting for the offset caused by a row insert.Test plan
I added a test to spec/unit/doc/worksheet.merge.spec for this issue and verified that it passes with the changes I made.