Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1198 Absolute path and relative path need to be compatible #1220

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Fix issue #1198 Absolute path and relative path need to be compatible #1220

merged 5 commits into from
Apr 29, 2020

Conversation

Alanscut
Copy link
Member

Changes

alubbe
alubbe reviewed Apr 27, 2020
View reviewed changes
spec/integration/pr/test-pr-1216.spec.js Outdated
const ExcelJS = verquire('exceljs');

describe('github issues', () => {
it('pull request 1216 - The worksheet should not be undefined', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be PR #1220 ? PR looks good otherwise

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alubbe I update the test case. thanks :).

@alubbe alubbe merged commit 726cda1 into exceljs:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alubbe alubbe alubbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alanscut @alubbe