Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add links to top with jump2header #1215

Merged
merged 3 commits into from
May 23, 2020

Conversation

strdr4605
Copy link
Contributor

Summary

Links back to Table of contents helps to navigate in the docs.

See demo.

@alubbe
Copy link
Member

alubbe commented May 20, 2020

Please merge the current master into your branch

@Siemienik
Copy link
Member

@strdr4605 thank you for this improvement :)
Could you (or any) perform the same thing for README_zh.md?

@Siemienik Siemienik merged commit 27dbeff into exceljs:master May 23, 2020
@Alanscut
Copy link
Member

hey @Siemienik, @alubbe , links now could back to table of contents, but the anchor of the contents failed, should we revert this PR or just fix it? and do you think this logo ⬆ looks too dazzling a bit weired? 😳

@strdr4605
Copy link
Contributor Author

The problem is with f65592e . Without space, everything should work ok. Should revert this PR and change.

and do you think this logo ⬆ looks too dazzling a bit weired?

There are other icons available also it is possible to change the position of the link.
Check jump2header#api.

@alubbe
Copy link
Member

alubbe commented May 25, 2020

I think that's github's default - not sure if they support a slimmer arrow
@strdr4605 could you open a PR reverting the change with the spaces?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants