Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #1057 Fix addConditionalFormatting is not a function error when using Streaming XLSX Writer #1143

Merged
merged 1 commit into from
Mar 29, 2020
Merged

fix issue #1057 Fix addConditionalFormatting is not a function error when using Streaming XLSX Writer #1143

merged 1 commit into from
Mar 29, 2020

Conversation

Alanscut
Copy link
Member

Change

@alubbe alubbe requested a review from guyonroche February 24, 2020 16:49
@alubbe
Copy link
Member

alubbe commented Feb 24, 2020

Looks great but I have no idea about whether the output XML is correct - @guyonroche would you mind taking a look at this one?

@alubbe alubbe mentioned this pull request Feb 24, 2020
Open
Siemienik
Siemienik approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alubbe alubbe merged commit cb8b11e into exceljs:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

@guyonroche guyonroche Awaiting requested review from guyonroche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alanscut @alubbe @Siemienik