Update TS definition to reference proper internal libraries #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace empty "Stream" interface with the Node internal "stream.Stream" interface * Replace empty "Writable" interface with the Node internal "events.EventEmitter" interface
|
@jakawell thanks for the fix. |
|
@jakawell - I've made a little progress. I've added a new test folder: spec/typescript with a couple of tests that execute ok but now they fail due to typescript compiler errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
When using the library with TypeScript, I noticed that a couple of empty interfaces were causing errors in the TS parsing. I checked the source code and verified the correct internal interfaces so that the typings are accurate.
I know unit tests are required for PRs, but I don't see anywhere in this project that it has unit tests for the TypeScript definition, and I'm not really sure how to do that (or if it would even be useful). Let me know if I'm wrong!