-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace zip dependencies for CompressionStream browser API #2703
Comments
This would also solve #713 (comment) 👍🏻 |
The above linked PR removes the node-unzipper dependency with another one (see #2687). The reason for doing so was: a) remove a security vulnerability in a transitive dependency of However, I believe what's suggested here is even better than using the I'm not even using this library, so I don't have the bandwidth to port this (and I'm not sure if it'll be merged, given the bump in minimum node version), but it'll probably be about a 4-8 hour patch? |
@alubbe @Siemienik @Alanscut Could you please investigate this issue? The node-unzipper library is no longer maintained and has known vulnerabilities. Consequently, we cannot use the |
🚀 Feature Proposal
Replace zip dependencies for the
CompressionStream
browser API.There might be a need for separate browser and server bundles.
Motivation
This project has a dependency on
jszip
,archiver
, andunzipper
:exceljs/package.json
Lines 98 to 108 in 5bed18b
which are bundlesize heavy https://bundlephobia.com/package/jszip, over 150 kB gzipped combined. Instead, we could use https://developer.mozilla.org/en-US/docs/Web/API/Compression_Streams_API. The browser support starts to be good enough.
The text was updated successfully, but these errors were encountered: