Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 4.1.0 causes TypeScript compilation errors - addRows styleOption should be optional? #1357

Closed
cduff opened this issue Jun 28, 2020 · 2 comments
Closed

[BUG] 4.1.0 causes TypeScript compilation errors - addRows styleOption should be optional? #1357

cduff opened this issue Jun 28, 2020 · 2 comments
Labels
bug

Comments

@cduff
Copy link

cduff commented Jun 28, 2020

🐛 Bug Report

Upgrading to 4.1.0 results in TypeScript compilation errors for previously working code like:

sheet.addRows(rows);

It looks like the problem was introduced in Added insert rows functionality with new style inherit options. The new TypeScript definition is:

addRows(rows: any[], styleOption: string): void;

Shouldn't styleOption be optional with a default value?
@sdg9670 sdg9670 mentioned this issue Jun 29, 2020
Merged
@Alanscut Alanscut added the bug label Jun 30, 2020
@Subhajitdas298
Copy link
Contributor

Sorry for the mishap. And thanks for quick response @sdg9670.
For the code, @cduff, If you are in hurry for release, you can use 'n' in styleOptions parameter.

@alubbe
Copy link
Member

alubbe commented Jun 30, 2020

Closing this, as we just need to wait for the release: #1362

@alubbe alubbe closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alubbe @cduff @Subhajitdas298 @Alanscut