Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: wrong createTag implementation in modules/tag.ts #886

Open
Aviksaikat opened this issue Nov 25, 2023 · 2 comments
Open

Bug: wrong createTag implementation in modules/tag.ts #886

Aviksaikat opened this issue Nov 25, 2023 · 2 comments
Labels
good first issue Good for newcomers type:issue

Comments

@Aviksaikat
Copy link

Overview

According to the docs the createTag is not taking account of the address parameter. As the parameter is not required but there should be an option to pass this.

file: modules/tag.ts

Solution

The correct implementation should be like this

export async function createTag(requestOptions: BeeRequestOptions, address: EthAddress | string): Promise<Tag> {
  const response = await http<Tag>(requestOptions, {
    method: 'post',
    url: endpoint,
    responseType: 'json',
   params: address
  })

  return response.data
}
@Cafe137
Copy link
Collaborator

Cafe137 commented Nov 28, 2023

Hello @Aviksaikat!

Thank you for identifying the issue and providing the code sample.

Would you be up to creating a PR so your contribution is properly recorded?

@Aviksaikat
Copy link
Author

sure thing

@Cafe137 Cafe137 added the good first issue Good for newcomers label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type:issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aviksaikat @Cafe137