Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [DOCS] Update non-existent pragma 0.4.99 to 0.5.0 #5732

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

ChrisChinchilla
Copy link
Contributor

@ChrisChinchilla ChrisChinchilla commented Jan 2, 2019

Description

Closes #3379 and specifically #3379 (comment) to ensure that all code examples use up to dat pragma versions.

Checklist

  • Code compiles correctly
  • All tests are passing
  • New tests have been created which fail without the change (if possible)
  • README / documentation was extended, if necessary
  • Changelog entry (if change is visible to the user)
  • Used meaningful commit messages

@@ -308,7 308,7 @@ This will no longer compile with Solidity v0.5.0. However, you can define a comp

::

pragma solidity >0.4.99 <0.6.0;
pragma solidity >0.5.0 <0.6.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be >=0.5.0 <0.6.0 or just ^0.5.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the previous >0.4.99 <0.6.0 is actually valid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axic I had barely pushed the branch ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axic It is? Then I am slightly confused now, was based on this comment - #3379 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the referenced issue. I think for these cases the proper solution is to use pragma solidity ^0.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @axic updated again :)

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #5732 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5732    /-   ##
========================================
  Coverage    88.24%   88.24%           
========================================
  Files          339      339           
  Lines        32818    32818           
  Branches      3937     3937           
========================================
  Hits         28961    28961           
  Misses        2507     2507           
  Partials      1350     1350
Flag Coverage Δ
#all 88.24% <ø> (ø) ⬆️
#syntax 28.26% <ø> (ø) ⬆️

@@ -308,7 308,7 @@ This will no longer compile with Solidity v0.5.0. However, you can define a comp

::

pragma solidity >0.4.99 <0.6.0;
pragma solidity ^0.5.0 <0.6.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess <0.6.0 could be removed.

Use correct syntax for pragma

Change pragma syntax

One more change to pragma syntax
@ChrisChinchilla
Copy link
Contributor Author

@chriseth Updated, rebased, squashed

@chriseth chriseth merged commit d9910f2 into develop Jan 7, 2019
@axic axic deleted the pragma-update branch January 22, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants