Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define how inheritance affects storage #5435

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Define how inheritance affects storage #5435

merged 1 commit into from
Nov 26, 2018

Conversation

fulldecent
Copy link
Contributor

Description

Checklist

  • Code compiles correctly
  • All tests are passing
  • New tests have been created which fail without the change (if possible)
  • README / documentation was extended, if necessary
  • Changelog entry (if change is visible to the user)
  • Used meaningful commit messages

@fulldecent fulldecent mentioned this pull request Nov 15, 2018
Closed
@codecov
Copy link

codecov bot commented Nov 15, 2018 •
edited
Loading

Codecov Report

Merging #5435 into develop will increase coverage by 59.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #5435        /-   ##
===========================================
  Coverage    29.07%   88.1%    59.03%     
===========================================
  Files          314     308        -6     
  Lines        31296   31182      -114     
  Branches      3771    3745       -26     
===========================================
  Hits          9099   27473     18374     
  Misses       21514    2455    -19059     
- Partials       683    1254       571
Flag Coverage Δ
#all 88.1% <ø> (?)
#syntax 29.04% <ø> (-0.03%) ⬇️

axic
axic reviewed Nov 21, 2018
View reviewed changes
docs/miscellaneous.rst Outdated
@@ -15,6 15,8 @@ Statically-sized variables (everything except mapping and dynamically-sized arra
- If an elementary type does not fit the remaining part of a storage slot, it is moved to the next storage slot.
- Structs and array data always start a new slot and occupy whole slots (but items inside a struct or array are packed tightly according to these rules).

The the contract uses inheritance, the ordering is determined as the C3-linearized order of contracts starting with the most base-ward contract.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "The the" what you've meant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f797d93

@axic axic requested a review from chriseth November 21, 2018 22:43
@chriseth chriseth merged commit d00082f into ethereum:develop Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic left review comments

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
documentation 📖 external contribution ⭐
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulldecent @axic @chriseth