Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(update): added deprecated tag to brownie and Cyfrin Updraft #15339

Closed
wants to merge 1 commit into from
Closed

docs(update): added deprecated tag to brownie and Cyfrin Updraft #15339

wants to merge 1 commit into from

Conversation

cromewar
Copy link

Updated Docs:

  • Added the deprecated tag to Brownie, as it is not maintained anymore.
  • Added Cyfrin Updraft to general resources as it is a great way to learn Solidity Development.
  • Added Aderyn to Solidity tools because is a nice Static analyzer tool for Solity.

@cromewar
docs(update): added deprecated tag to brownie as is not mantained any…
bda9b79 
… more, added Cyfrin Updraft under general resources and Aderyn into Solidity tools
@github-actions GitHub Actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@r0qs r0qs requested a review from mehtavishwa30 August 19, 2024 11:41
@r0qs r0qs mentioned this pull request Sep 16, 2024
Merged
mehtavishwa30
mehtavishwa30 reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mehtavishwa30 mehtavishwa30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cromewar!

Thank you for your contribution. There is currently an ongoing update that will add appropriate additional resources and bring the existing items in the list up-to-date in a PR (see: #15076).

We will be reviewing and combining smaller individual PRs like yours in a single change. :)

@PatrickAlphaC
Copy link
Contributor

Hello! Any update on this PR?

ibrahimkhled
ibrahimkhled reviewed Nov 11, 2024
View reviewed changes
Copy link

@ibrahimkhled ibrahimkhled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__

docs/resources.rst
@@ -15,11 15,12 @@ General Resources
* `Awesome Solidity <https://github.com/bkrem/awesome-solidity>`_
* `Solidity by Example <https://solidity-by-example.org/>`_
* `Solidity Documentation Community Translations <https://github.com/solidity-docs>`_
* `Cyfrin Updraft - The Leading Educative Platform for Blockchain Developers <https://updraft.cyfrin.io/>`_
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/resources.rst

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! Thank you

@PatrickAlphaC
Copy link
Contributor

@cameel should we make a new PR for this? Or is it not wanted.

@cameel
Copy link
Member

cameel commented Dec 5, 2024

It was closed along with a few others that became redundant after #15076. So that's a question to @mehtavishwa30.

@mehtavishwa30
Copy link
Contributor

Hey @PatrickAlphaC! Apologies for the missing clarification earlier. We had several external PRs to update the resources page that were accommodated in #15076.

From @cromewar's PR,

  • I added a note to address the deprecation of Brownie as suggested
  • Also added in Aderyn (great suggestion!)
  • I left out Updraft because IMO, it doesn't fit under our general resources section, as all resources focused on education continue to live on the ethereum.org developer portal instead.

I hope this is helpful! Lmk if you have thoughts. :)

@PatrickAlphaC
Copy link
Contributor

Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimkhled ibrahimkhled ibrahimkhled left review comments

@PatrickAlphaC PatrickAlphaC PatrickAlphaC left review comments

@mehtavishwa30 mehtavishwa30 mehtavishwa30 left review comments

Assignees
No one assigned
Labels
documentation 📖 external contribution ⭐
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cromewar @PatrickAlphaC @cameel @mehtavishwa30 @ibrahimkhled @r0qs