Add output selection support for ethdebug #15293
Conversation
aarlt
added
the
has dependencies
There was a problem hiding this comment.
Looks good to me. I was wondering if it would also be an option to throw in case the output is requested (together with the appropriate debug-info flag) as you're essentially just swallowing it now which might confuse someone unsuspecting. But then again it's not listed in the options so I think it's fine this way as well.
cameel
changed the title
|
I will still add the standard-json import part to this PR. This part I didn't pushed yet, because I saw that I need to add additional tests to verify validation logic. I will add this later today. |
| @@ -995,6 996,8 @@ void CommandLineInterface::handleCombinedJSON() | |||
| contractData[g_strFunDebugRuntime] = StandardCompiler::formatFunctionDebugData( | |||
| m_assemblyStack->runtimeObject(contractName).functionDebugData | |||
| ); | |||
| if (m_options.compiler.combinedJsonRequests->ethdebug) | |||
| contractData[g_strEthdebug] = Json::object(); | |||
There was a problem hiding this comment.
Combined JSON has been deprecated for ages now (#10278) and we're likely to drop it in the next breaking release. It does not make sense add more things to it at this point.
This should be standalone compiler output instead.
aarlt
force-pushed
the
add_ethdebug_output_selection
branch
from
5ef3239
to
77c474a
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
5 times, most recently
from
ec729b3
to
ee2bc12
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
from
ee2bc12
to
9772d20
Compare
|
Replaced by #15289. |
Depends on #15289.