Update the "Resources" section in the docs #15076
Conversation
cameel
changed the title
github-actions
bot
added
the
stale
nikola-matic
removed
the
stale
github-actions
bot
added
the
stale
|
This pull request was closed due to a lack of activity for 7 days after it was stale. |
nikola-matic
force-pushed
the
mehtavishwa30-patch-1
branch
from
a1d0cd0 to
3422401
Compare
cameel
removed
stale
|
There was an error when running Please check that your changes are working as intended. |
mehtavishwa30
force-pushed
the
mehtavishwa30-patch-1
branch
from
37818e0 to
81d0ed4
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
|
Relevant |
mehtavishwa30
removed
the
stale
There was a problem hiding this comment.
The changes look good to me now, we just need to squash the commits. I was also wondering if we could merge the changes proposed in this PR: #15339, or possibly even close it. I haven’t looked too closely at the tools being proposed - although the static analyzer seems nice - but since we're working on the same docs and there’s some overlap in the changes, this might be a good time to make a decision on that.
| * `Solidity website <https://soliditylang.org/>`_ | ||
| * `Solidity changelog <https://github.com/ethereum/solidity/blob/develop/Changelog.md>`_ | ||
| * `Solidity codebase on GitHub <https://github.com/ethereum/solidity/>`_ | ||
| * `Solidity language users chat <https://matrix.to/#/#ethereum_solidity:gitter.im>`_ | ||
| * `Solidity compiler developers chat <https://matrix.to/#/#ethereum_solidity-dev:gitter.im>`_ | ||
| * `awesome-solidity <https://github.com/bkrem/awesome-solidity>`_ |
There was a problem hiding this comment.
This still not in alphabetical order, but I guess the idea was to keep it as it was before, right?
There was a problem hiding this comment.
That's correct. Just made minor naming changes in the title that I thought were more appropriate. But otherwise, I'm not strongly set on the order.
@r0qs Thanks for the review. I wanted to get to this today. Just caught up in some other issues. The idea is to consolidate the changes proposed in the external contribution, so I will ask for a final review once I've included those. :) |
No problem. But yeah, that was just a suggestion though, because we have so many documentation PRs that have small changes, that maybe we could combine some of them. For example, this may also be relevant to add here or just close it: #15234 |
github-actions
bot
added
the
stale
mehtavishwa30
removed
the
stale
|
There was an error when running Please check that your changes are working as intended. |
| * `Solidity website <https://soliditylang.org/>`_ | ||
| * `Solidity changelog <https://github.com/ethereum/solidity/blob/develop/Changelog.md>`_ | ||
| * `Solidity codebase on GitHub <https://github.com/ethereum/solidity/>`_ | ||
| * `Solidity language users chat <https://matrix.to/#/#ethereum_solidity:gitter.im>`_ |
There was a problem hiding this comment.
Why did you move this to lower caps? The previous style is more consistent with the rest of our docs.
There was a problem hiding this comment.
it just looked a little weird, IMO, in that earlier format. But I don't think it's too big of a deal. LMK if you think I should change it back or if it's okay as is now.
|
BTW, you could list all the other redundant PRs in your description and github will automatically close them when we merge this one. That would make it easier to keep track of them, because we have quite a few now. To do this write something like |
Co-authored-by: Nikola Matić <[email protected]>
Co-authored-by: Nikola Matić <[email protected]>
cameel
force-pushed
the
mehtavishwa30-patch-1
branch
from
f6290b4 to
3bba192
Compare
Closes #15339
Closes #15234
Closes #15575