Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for delete operator on UDVT #14633

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

xBA5ED
Copy link

@xBA5ED xBA5ED commented Oct 22, 2023

Fixes #12273

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@ekpyron
Copy link
Member

ekpyron commented Oct 30, 2023

This would need semantics tests checking for sane behavior and a changelog entry, if we're to merge it.

@xBA5ED
Copy link
Author

xBA5ED commented Oct 31, 2023

I added semantic tests, the changelog entry and rebased the PR. If there is missing test coverage or if there are any other changes needed let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow delete on user-defined value types
2 participants