docs: add the onlyBuyer modifier in function confirmPurchase() #14632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the function confirmPurchase(), the annotation said 'Confirm the purchase as buyer.' but it doesn't add the `onlyBuyer` modifier
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
mehtavishwa30
approved these changes
Aug 19, 2024
ekpyron
reviewed
Aug 19, 2024
| @@ -106,6 106,7 @@ you can use state machine-like constructs inside a contract. | |||
| /// is called. | |||
| function confirmPurchase() | |||
| external | |||
| onlyBuyer | |||
There was a problem hiding this comment.
It's only confirmPurchase here that sets buyer in the first place (see the second line in the body), so this change is invalid: after the change it'd be impossible to confirm a purchase.
mehtavishwa30
added a commit
that referenced
this pull request
Aug 19, 2024
Reverts the docs PR #14632. (see: #14632 (comment))
clonker
pushed a commit
that referenced
this pull request
Aug 28, 2024
Reverts the docs PR #14632. (see: #14632 (comment))
aarlt
pushed a commit
that referenced
this pull request
Sep 4, 2024
Reverts the docs PR #14632. (see: #14632 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the
function confirmPurchase(), the annotation said 'Confirm the purchase as buyer.' but it doesn't add theonlyBuyermodifier