Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Randomness in Phaser Tests #12488

Open
ekpyron opened this issue Jan 4, 2022 · 0 comments
Open

Check Randomness in Phaser Tests #12488

ekpyron opened this issue Jan 4, 2022 · 0 comments
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap. testing 🔨

Comments

@ekpyron
Copy link
Member

ekpyron commented Jan 4, 2022

The phaser tests use partly fixed partly time-based seeds, so the choice of tests will affect behaviour.
@cameel wanted to look into them on a per-case basis.

I'd suggest to give all of them a fixed seed by default and add an soltest option with a nightly run that changes that behaviour to random seeds (and maybe higher sample sizes to avoid failures then, since runtime will be less of a concern).

@ekpyron ekpyron added the feature label Jan 4, 2022
@cameel cameel added bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap. labels Feb 25, 2023
@cameel cameel removed their assignment Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap. testing 🔨
Projects
None yet
Development

No branches or pull requests

2 participants